[PATCH] D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line

[Victor Huang via Phabricator via llvm-commits]

NeHuang added a comment.

Overall looks good to me. Some minor changes needed.



================
Comment at: llvm/test/CodeGen/PowerPC/absol-jump-table-enabled.ll:1
+; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu -o - \
+; RUN:     -ppc-use-absolute-jumptables -ppc-asm-full-reg-names \
----------------
Please add a brief note at the top stating what you are testing here. 


================
Comment at: llvm/test/CodeGen/PowerPC/absol-jump-table-enabled.ll:18
+; CHECK-LE:       bctr
+; CHECK-LE:	  blr
+;
----------------
nit: alignment of blr 


================
Comment at: llvm/test/CodeGen/PowerPC/absol-jump-table-enabled.ll:20
+;
+; CHECK-BE-LABEL:  jumpTableTest:
+; CHECK-BE:       # %bb.0: # %entry
----------------
nit: alignment of jumpTableTest (one less space)


================
Comment at: llvm/test/CodeGen/PowerPC/absol-jump-table-enabled.ll:26
+; CHECK-BE:       bctr
+; CHECK-BE:	  blr
+entry:
----------------
nit: alignment of blr 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69108/new/

https://reviews.llvm.org/D69108