[PATCH] D69040: [TTI][LV] preferPredicateOverEpilogue

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 06:03:27 PDT 2019


SjoerdMeijer added a comment.

> Thinking about this some more, I think it would be best to at least check some features of the loop for legality:
> 
>   - no vector widths greater than 128 bits.
> - all vector operations should have the same number of lanes.

Yep, this is exactly what I wanted to do in the follow up as this is mostly target dependent.
But you do have good points, and perhaps addressing some of that now is a good thing. And so, looking into things now, what I wanted to implement in the target specific part, is something very similar to `LoopVectorizationCostModel::getSmallestAndWidestTypes`. I will reuse that, and also pass the smallest and widest type to `preferPredicateOverEpilogue`, this is the info we need for the legality checks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69040/new/

https://reviews.llvm.org/D69040





More information about the llvm-commits mailing list