[PATCH] D57779: [SLP] Add support for throttling.

Thu Oct 17 05:07:18 PDT 2019

dtemirbulatov marked 2 inline comments as done.
dtemirbulatov added inline comments.

================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:5523
+
+    // Partially vectorize trees after all full vectorization is done,
+    // otherwise, we could prevent more profitable full vectorization with
----------------
dtemirbulatov wrote:
> ABataev wrote:
> > dtemirbulatov wrote:
> > > vporpo wrote:
> > > > I don't think throttling should be visible at this level. It should be called after the call to getTreeCost().
> > > I have seen so many regressions where partial vectorization prevents more profitable full vectorization and I think it is unacceptable to allow any and I think it is a good solution to those issues and It is not time-consuming we already done dependancy analysis at this point for all those seeds.  I will double check.
> > What about this?
> Discussed at line #645
Done

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779