[PATCH] D69064: [ARM] Add dependency on GlobalISel for unit tests to fix shared libs build

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai marked 2 inline comments as done.
nemanjai added inline comments.


================
Comment at: unittests/CodeGen/CMakeLists.txt:12
   Target
+  GlobalISel
   )
----------------
rovka wrote:
> Why is this necessary? There's a subdirectory for GlobalISel, if some unit test in here is pulling in GlobalISel it's worth investigating why.
Sorry, I probably should have added that to the description. It is missing vtables for two classes.

```
unittests/Target/ARM/CMakeFiles/ARMTests.dir/MachineInstrTest.cpp.o:(.toc+0x0): undefined reference to `vtable for llvm::RegisterBankInfo'
unittests/Target/ARM/CMakeFiles/ARMTests.dir/MachineInstrTest.cpp.o:(.toc+0x8): undefined reference to `vtable for llvm::LegalizerInfo'
```

Build info:
GCC build compiler: 7.3.1
CMake vars: `-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DBUILD_SHARED_LIBS=ON`
OS: Ubuntu 16.04.6


================
Comment at: unittests/Target/ARM/CMakeLists.txt:15
   Target
+  GlobalISel
 )
----------------
rovka wrote:
> Nit; These lists are sorted alphabetically.
Oops, sorry about that. I'll reorder them.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69064/new/

https://reviews.llvm.org/D69064