[PATCH] D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default.

Thu Oct 17 02:30:23 PDT 2019

grimar added a comment.

In D69041#1712474 <https://reviews.llvm.org/D69041#1712474>, @kwk wrote:

> In D69041#1712432 <https://reviews.llvm.org/D69041#1712432>, @grimar wrote:
>
> > In D69041#1711707 <https://reviews.llvm.org/D69041#1711707>, @kwk wrote:
> >
> > > @grimar I don't understand why you created this patch, when I'm working on it already.
> >
> >
> > I only wanted to help, because supposed that the correct direction is not clear for you (since your version did not fix any of existent test cases that were failing,
> >  obj2yaml tool did not compile and there was at least one obliously wrong place in 'initSymtabSectionHeader' that broke the normal logic).
> >  And it was also not fully clear to me what is exactly needed until I run check-llvm with the first more or less stable version of the patch at least.
> >
> > Now when the whole picture is revealed, feel free to commandeer this revision or use it as a reference for your patch if you would like to continue it.
> >  Or let me continue. Please let me know about your decision, I'll put this on hold until that.
>
>
> @grimar I'm really sorry that I wrote this yesterday. I'm working crazy hours lately and wasn't in a bad mood. I understand why you wrote the patch now. But since it wasn't something urgent to do and only motivated because I brought it up, I didn't fully understood how little time I was given to react to your comments in my own patch. I will discontinue it as you obviously have more experience in the yaml2obj and obj2yaml code. What's bugging me is just that I wanted to contribute and didn't have enough time to properly do so, that's all.

No problems. Hope we will land it soon :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69041/new/

https://reviews.llvm.org/D69041