[PATCH] D68945: [DebugInfo] Don't translate dbg.addr and similar intrinsics into indirect DBG_VALUEs

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

I'm working in this area for pr41992 so I noticed a couple of things (inline comments). I am happy to just add the changes I'm suggesting into my own upcoming patch if you'd like?



================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:105
     static_assert(sizeof(*this) == sizeof(unsigned), "bad bitfield packing");
     assert(locNo() == LocNo && "location truncation");
   }
----------------
I don't think either of these asserts are necessary now. Or, at least the first one's message needs updating to something like "expected DbgValueLocation to be pointer size".


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:112
     // Fix up the undef location number, which gets truncated.
     return LocNo == INT_MAX ? UndefLocNo : LocNo;
   }
----------------
I think this should have been updated. Previously the LocNo was 31 bits and UndefLocNo is defined above as ~0u, so after assigning LocNo = UndefLocNo, LocNo == INT_MAX. Now it's just equal to UndefLocNo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68945/new/

https://reviews.llvm.org/D68945