[PATCH] D64906: [ELF][PPC] Allow PT_LOAD to have overlapping p_offset ranges

[Troy Johnson via Phabricator via llvm-commits]

troyj added a comment.

>   p->p_memsz = alignTo(p->p_offset + p->p_memsz, config->commonPageSize) - p->p_offset;

I think the whole rounding step is questionable, not simply this change to it.  As far as I can tell from researching this, the rounding down that occurs is for the starting address to place RELRO on a page boundary.  The size of RELRO does not get rounded down, so rounding it up here by any amount risks making more data read-only than is necessary, which can lead to seg faults.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64906/new/

https://reviews.llvm.org/D64906