[PATCH] D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 01:46:41 PDT 2019


grimar added a comment.

In D69041#1711707 <https://reviews.llvm.org/D69041#1711707>, @kwk wrote:

> @grimar I don't understand why you created this patch, when I'm working on it already.


I only wanted to help, because supposed that the correct direction is not clear for you (since your version did not fix any of existent test cases that were failing,
obj2yaml tool did not compile and there was at least one obliously wrong place in 'initSymtabSectionHeader' that broke the normal logic).
And it was also not fully clear to me what is exactly needed until I run check-llvm with the first more or less stable version of the patch at least.

Now when the whole picture is revealed, feel free to commandeer this revision or use it as a reference for your patch if you would like to continue it.
Or let me continue. Please let me know about your decision, I'll put this on hold until that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69041/new/

https://reviews.llvm.org/D69041





More information about the llvm-commits mailing list