[PATCH] D69087: [llvm-ar] Implement the O modifier: display member offsets inside the archive

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: tools/llvm-ar/llvm-ar.cpp:498
+    if (DisplayOffsets)
+      (outs() << " 0x").write_hex(C.getDataOffset());
   }
----------------
This code surprised me a little bit, although it is correct. I'd use utohexstr and operator<< instead of raw_ostream::write_hex.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69087/new/

https://reviews.llvm.org/D69087