[PATCH] D69073: [lld][WebAssembly] Fix for weak references to data symbols in archives

[Sam Clegg via Phabricator via llvm-commits]

sbc100 updated this revision to Diff 225343.
sbc100 added a comment.

- comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69073/new/

https://reviews.llvm.org/D69073

Files:
  lld/test/wasm/archive-weak-undefined.ll
  lld/wasm/InputFiles.cpp


Index: lld/wasm/InputFiles.cpp
===================================================================
--- lld/wasm/InputFiles.cpp
+++ lld/wasm/InputFiles.cpp
@@ -189,7 +189,7 @@
   case R_WASM_MEMORY_ADDR_I32:
   case R_WASM_MEMORY_ADDR_LEB:
   case R_WASM_MEMORY_ADDR_REL_SLEB:
-    if (isa<UndefinedData>(sym))
+    if (isa<UndefinedData>(sym) || sym->isUndefWeak())
       return 0;
     return cast<DefinedData>(sym)->getVirtualAddress() + reloc.Addend;
   case R_WASM_TYPE_INDEX_LEB:
Index: lld/test/wasm/archive-weak-undefined.ll
===================================================================
--- lld/test/wasm/archive-weak-undefined.ll
+++ lld/test/wasm/archive-weak-undefined.ll
@@ -1,19 +1,39 @@
+; Test that weak undefined symbols do not fetch members from archive files.
 ; RUN: llc -filetype=obj %s -o %t.o
-; RUN: llc -filetype=obj %S/Inputs/ret32.ll -o %t.a1.o
+; RUN: llc -filetype=obj %S/Inputs/ret32.ll -o %t.ret32.o
+; RUN: llc -filetype=obj %S/Inputs/hello.ll -o %t.hello.o
 ; RUN: rm -f %t.a
-; RUN: llvm-ar rcs %t.a %t.a1.o
+; RUN: llvm-ar rcs %t.a %t.ret32.o %t.hello.o
+
 ; RUN: wasm-ld %t.o %t.a -o %t.wasm
 ; RUN: obj2yaml %t.wasm | FileCheck %s
 
+; RUN: wasm-ld -u hello_str %t.o %t.a -o %t2.wasm
+; RUN: obj2yaml %t2.wasm | FileCheck %s -check-prefix=CHECK-DATA
+
 target triple = "wasm32-unknown-unknown"
 
+; Weak external function symbol
 declare extern_weak i32 @ret32()
 
+; Weak external data symbol
+ at hello_str = extern_weak global i8*, align 4
+
 define void @_start() {
-entry:
+  br i1 icmp ne (i8** @hello_str, i8** null), label %if.then, label %if.end
+
+if.then:
   %call1 = call i32 @ret32()
+  br label %if.end
+
+if.end:
   ret void
 }
 
+; Ensure we have no data section.  If we do, would mean that hello_str was
+; pulled out of the library.
+; CHECK-NOT:  Type:            DATA
+; CHECK-DATA: Type:            DATA
+
 ; CHECK: Name: 'undefined:ret32'
 ; CHECK-NOT: Name: ret32


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69073.225343.patch
Type: text/x-patch
Size: 1926 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191017/528991d5/attachment.bin>