[PATCH] D65541: [llvm-objcopy][MachO] Implement --only-section

Wed Oct 16 18:55:54 PDT 2019

seiya marked 2 inline comments as done.
seiya added a comment.

Thank you for your review!

In D65541#1711938 <https://reviews.llvm.org/D65541#1711938>, @alexshap wrote:

> @seiya - thanks for all your work, I'm wondering - can you commit this change / is there anything blocking this diff ?

There're no diffs that blocks this patch. I'll commit this patch along with D66280 <https://reviews.llvm.org/D66280> and D66281 <https://reviews.llvm.org/D66281>.

Other Mach-O support patches for llvm-objcopy needs addressing some review comments. I'll let you know once I update them.

================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:338
+                             Pair.first.str().c_str());
+  if (Pair.second.size() > 16)
+    return createStringError(errc::invalid_argument,
----------------
alexshap wrote:
> khm, maybe there is a named constant for this ? (somewhere in llvm::MachO:: )
I've git-grep'ed through llvm::MachO and lld but there were no constant for it (lld hard-codes the value).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65541/new/

https://reviews.llvm.org/D65541