[PATCH] D68992: [DFAPacketizer] Use DFAEmitter. NFC.

Thomas Raoux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 17:38:00 PDT 2019


ThomasRaoux accepted this revision.
ThomasRaoux added a comment.
This revision is now accepted and ready to land.

Awesome cleanup!



================
Comment at: llvm/include/llvm/CodeGen/DFAPacketizer.h:81
   const InstrItineraryData *InstrItins;
-  int CurrentState = 0;
-  const DFAStateInput (*DFAStateInputTable)[2];
-  const unsigned *DFAStateEntryTable;
-  const unsigned (*DFAResourceTransitionTable)[2];
-  const unsigned *DFAResourceTransitionEntryTable;
-
-  // CachedTable is a map from <FromState, Input> to ToState.
-  DenseMap<UnsignPair, unsigned> CachedTable;
-  // CachedResourceTransitions is a map from <FromState, Input> to a list of
-  // resource transitions.
-  DenseMap<UnsignPair, ArrayRef<unsigned[2]>>
-      CachedResourceTransitions;
-
-  // Read the DFA transition table and update CachedTable.
-  void ReadTable(unsigned state);
-
-  bool TrackResources = false;
-  // State for the current packet. Every entry is a possible packing of the
-  // bundle, indexed by cumulative resource state. Each entry is a list of the
-  // cumulative resource states after packing each instruction. For example if
-  // we pack I0: [0x4] and I1: [0x2] we will end up with:
-  //   ResourceStates[0x6] = [0x4, 0x6]
-  DenseMap<unsigned, SmallVector<unsigned, 8>> ResourceStates;
+  Automaton<uint64_t> A;
 
----------------
Should it be Automaton<DFAInput> for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68992/new/

https://reviews.llvm.org/D68992





More information about the llvm-commits mailing list