[PATCH] D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition

[Volkan Keles via Phabricator via llvm-commits]

volkan accepted this revision.
volkan added a comment.
This revision is now accepted and ready to land.

Thanks for explaining, LGTM.



================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:282
+         << Indent << "      "
+         << CodeExpander(Rule->getCode()->getValue(), Expansions,
+                         Rule->getCode()->getLoc(), ShowExpansions)
----------------
dsanders wrote:
> volkan wrote:
> > Don't we need to get the Matcher here as we do that for Applyer below?
> At the moment, the matcher can only contain a code block and this is essentially a trap-door that allows me to fix up the generated code and keep things working while the features are going in. I could rename getCode() to getMatcherFixupCode() if that helps.
I think that would make it easier to understand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68426/new/

https://reviews.llvm.org/D68426