[PATCH] D69070: [PGO][PGSO] SizeOpts changes.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSizeOpts.cpp:29
+/// Like ProfileSummaryInfo::isColdBlock but for MachineBasicBlock.
+bool isColdBlock(const MachineBasicBlock *MBB,
+                 ProfileSummaryInfo *PSI,
----------------
Is it possible to expose these APIs publicly in the future ? if yes, maybe put it in llvm:: namespace.


================
Comment at: llvm/lib/CodeGen/MachineSizeOpts.cpp:79
+namespace {
+struct MachineBasicBlockBFIAdapter {
+  static bool isFunctionColdInCallGraph(const MachineFunction *MF,
----------------
Is this adapter class needed? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69070/new/

https://reviews.llvm.org/D69070