[PATCH] D68833: [CMake] Re-order runtimes in the order of dependencies

Wed Oct 16 12:03:16 PDT 2019

ldionne added a comment.

In D68833#1706696 <https://reviews.llvm.org/D68833#1706696>, @phosek wrote:

> In D68833#1706544 <https://reviews.llvm.org/D68833#1706544>, @beanz wrote:
>
> > That is a much better approach. CMake 3.11 is when the `TARGET_EXISTS` generator expression was added, although the documentation wasn't updated until CMake 3.15, so this change would require a CMake version update, which I don't think is unreasonable.
>
>
> I've tested D68880 <https://reviews.llvm.org/D68880> which requires newer CMake but it does seem to be working. Shall we start the discussion about bumping the minimum CMake version requirement on llvm-dev?

Yes, I think that would be great. CMake is one of those programs that's terribly easy to install, and I think it's reasonable to request a recent CMake in order to build LLVM (or at least libc++).

If the rest of LLVM wants/needs to stay stuck on CMake 3.4 (!!!), it might be possible to move the requirements for libc++/libc++abi only.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68833/new/

https://reviews.llvm.org/D68833