[PATCH] D69030: [cmake] Suppress unknown argument warning when linking with lld-link

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Hm, we don't see these warnings. We use `CMAKE_LINKER=C:/b/s/w/ir/cache/builder/src/third_party/llvm-bootstrap-install/bin/lld-link.exe` to make cmake use lld-link. It looks like the bot you link to explicitly sets `-DLLVM_USE_LINKER=lld` which I always figured translates to "pass this -fuse-ld" flag. So I'd say the bot configuration is maybe not quite right? I'd fix that instead.

Maybe we should have a "LLVM_USE_LINKER" and CMAKE_LINKER can't be set at the same time" warning instead?

But if this change helps you somehow, I don't see a problem with landing it either.

(But again, for the bot you link to, I'd argue a better fix is to make it set fewer cmake settings.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69030/new/

https://reviews.llvm.org/D69030