[PATCH] D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 16 09:22:45 PDT 2019
MaskRay added inline comments.
================
Comment at: lib/ObjectYAML/ELFEmitter.cpp:208
+ // Some sections wants to link to .symtab by default.
+ // That means we want to create the symbol table for them.
+ if (D->Type == llvm::ELF::SHT_REL || D->Type == llvm::ELF::SHT_RELA ||
----------------
`if (Doc.Symbols) continue;` can be factored out.
================
Comment at: test/tools/yaml2obj/symtab-implicit-sections-flags.yaml:80
Machine: EM_X86_64
+Symbols:
----------------
In other places, you seem to use `Symbols: []`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69041/new/
https://reviews.llvm.org/D69041
More information about the llvm-commits
mailing list