[PATCH] D65850: GlobalISel: pack various parameters for lowerCall into a struct.

[Marco Antognini via Phabricator via llvm-commits]

mantognini added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:252
+  virtual bool lowerCall(MachineIRBuilder &MIRBuilder,
+                         CallLoweringInfo &Info) const {
     return false;
----------------
I was wondering about this change. The previous arguments are either values or `const&`, but the new argument is a non-const reference. Is that intentional (i.e. is it meant that in the future, or even now, implementations of `lowerCall` should/can modify this argument), or can the argument be turned into a `const&`? The documentation doesn't say much, so I'm assuming the latter is true. Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65850/new/

https://reviews.llvm.org/D65850