[PATCH] D69028: [DebugInfo] Correctly place DW_OP_derefs for arguments passed on stack

Wed Oct 16 08:27:33 PDT 2019

jmorse added a comment.

In D69028#1711085 <https://reviews.llvm.org/D69028#1711085>, @probinson wrote:

> Just to clarify things in my own mind:  dbg.declare expressions describe a location, while dbg.value expressions describe a value?  And that's why you're wanting to add a trailing deref?

Yup, that's correct. I repeatedly screw up the correct use of the term "location", so to be super explicit, dbg.declare always describes a _memory_ location.

> Then when we emit the actual DWARF, the trailing deref is omitted so the expression again describes a location.

Indeed.

As suggested in https://reviews.llvm.org/D68945#1710656 , I'd enjoy a future where the DwarfExpression code didn't have to guess what kind of location we were dealing with (no "unknown" state).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69028/new/

https://reviews.llvm.org/D69028