[PATCH] D68636: [llvm-readobj] - Refine the LLVM-style output to be consistent.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D68636#1710892 <https://reviews.llvm.org/D68636#1710892>, @grimar wrote:

> Fangrui, so do you mean you are agree with the following renaming?
>
>   SHT_GNU_verdef { -> VersionDefinitions [
>   SHT_GNU_verneed { -> VersionRequirements
>
>
> (this patch was in "planned changes" status and needs a rebasing, then some changes will go away I think,
>  but this renaming disagreement was the reason I've not update it. If it is OK for you,
>  I'll probably need to do one more update for it).


Yes, I think the renaming is right (I was on a subway, so it was inconvenient for me to make more comments). I think I proposed a scheme that I don't like myself ;-) glibc names SHT_GNU_versym `#define SHT_GNU_versym	  0x6fffffff	/* Version symbol table.  */`. It is totally fine to name it `VersionSymbols` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68636/new/

https://reviews.llvm.org/D68636