[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

Tue Oct 15 03:23:27 PDT 2019

lewis-revill added a comment.

In D62686#1708792 <https://reviews.llvm.org/D62686#1708792>, @apazos wrote:

> Yes Eli thanks for pointing out  there are more scenarios that can fail.
>  It looks like the best solution is to permit both flags on, but then bail out from doing this transformation if there is any type of tail call already in the function.
>  This way we avoid messing with reverting tail calls back to regular calls.

Is it worth trying to disallow tail call optimization completely if this flag is enabled? I'm not sure what GCC does exactly. but this seems to be the behaviour.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62686/new/

https://reviews.llvm.org/D62686