[PATCH] D69040: [TTI][LV] preferPredicateOverEpilogue

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1003
+  // extension of v8.1-m.
+  if (!ST->hasLOB() || DisableLowOverheadLoops)
+    return false;
----------------
What about MVE..? We also need to have masked load/stores enabled.


================
Comment at: llvm/test/Transforms/LoopVectorize/ARM/tail-loop-folding.ll:10
 
+define dso_local void @tail_folding(i32* noalias nocapture %A, i32* noalias nocapture readonly %B, i32* noalias nocapture readonly %C) #0 {
+; CHECK-LABEL: tail_folding(
----------------
I think it's worth adding your tests now for the conditions that you're adding, even if this means adding an extra backend command to enable/disable tail predication. I imagine we'll be testing for a while so I think it's worth it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69040/new/

https://reviews.llvm.org/D69040