[PATCH] D68976: [ARM] Add qadd lowering from a sadd_sat

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 06:12:43 PDT 2019


samparker added a comment.

LGTM.



================
Comment at: llvm/test/CodeGen/ARM/qdadd.ll:45
+; CHECK-ARM:       @ %bb.0:
+; CHECK-ARM-NEXT:    qadd r0, r0, r0
+; CHECK-ARM-NEXT:    qadd r0, r0, r1
----------------
dmgreen wrote:
> samparker wrote:
> > Still need the tablegen patterns!
> D68999. I thought I had put that somewhere here, but perhaps I had just presumed you would get the notification.
> 
> I rebased these tests, which is why they appear here too. That patch adds the patterns.
Ah!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68976/new/

https://reviews.llvm.org/D68976





More information about the llvm-commits mailing list