[PATCH] D68983: [yaml2obj, obj2yaml] - Add support for SHT_NOTE sections.

Wed Oct 16 03:10:52 PDT 2019

grimar updated this revision to Diff 225186.
grimar added a comment.

- Implement `NoteEntry::Desc` as `yaml::BinaryRef` instead of `StringRef`. Description is not a null-terminated string, but a binary data. Previous implementation tried to use `StringRef`, but it was incorrect, it produced wrong output.
- Fix the code and one more test case (seems I've forgot to do a final tests run before posting).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68983/new/

https://reviews.llvm.org/D68983

Files:
  include/llvm/ObjectYAML/ELFYAML.h
  include/llvm/Support/YAMLTraits.h
  lib/ObjectYAML/ELFEmitter.cpp
  lib/ObjectYAML/ELFYAML.cpp
  test/tools/obj2yaml/elf-sht-note.yaml
  test/tools/yaml2obj/elf-sht-note.yaml
  test/tools/yaml2obj/implicit-sections-types.test
  tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68983.225186.patch
Type: text/x-patch
Size: 21906 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191016/dd85f6ac/attachment.bin>