[PATCH] D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine

Wed Oct 16 03:08:27 PDT 2019

joanlluch added a comment.

In D68982#1710606 <https://reviews.llvm.org/D68982#1710606>, @asl wrote:

> @joanlluch There are two things here. We understand that there might be some out-of-tree targets that would benefit from changes in the mainline. However, it is still important to add tests that utilize mainline targets as this ensures that the proposed changes won't e.g. break during some refactoring, etc. So, using MSP430 (probably the smallest) / AVR is perfectly fine for tests, etc.!

I fully understand and agree on that, and I will adhere to it. Still, I found some few cases of LLVM improvements regarding the direction of this patch, that will not fully show on MSP430 because of reversals implemented in the target itself, but I will try to make mentions of them in due term. Thanks again for your support.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68982/new/

https://reviews.llvm.org/D68982