[PATCH] D68946: [MIParser] Set RegClassOrRegBank during instruction parsing

Wed Oct 16 03:08:27 PDT 2019

Petar.Avramovic marked an inline comment as done.
Petar.Avramovic added inline comments.

================
Comment at: test/CodeGen/MIR/Mips/setRegClassOrRegBank.mir:2
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -O0 -mtriple=mipsel-linux-gnu -global-isel -mcpu=mips32r5 -mattr=msa,+fp64 -mattr=nan2008 -run-pass=legalizer -verify-machineinstrs %s -o - | FileCheck %s -check-prefixes=P5600

----------------
arsenm wrote:
> The parser test shouldn't be running the legalizer?  -O0 and -global-isel are also unnecessary 
The change affects internal state of MachineRegisterInfo and is not visible if we only do the parsing ( -run-pass=none ), but is visible when we try to `constrainSelectedInstRegOperands`. 
I saw a few tests with -run-pass other then none, e.g. 
`test/CodeGen/MIR/AArch64/print-parse-verify-failedISel-property.mir`
`test/CodeGen/MIR/AArch64/print-parse-overloaded-intrinsics.mir`.
Any suggestions how to make better test?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68946/new/

https://reviews.llvm.org/D68946