[PATCH] D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine
    Anton Korobeynikov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Oct 16 02:32:05 PDT 2019
    
    
  
asl added a comment.
@joanlluch There are two things here. We understand that there might be some out-of-tree targets that would benefit from changes in the mainline. However, it is still important to add tests that utilize mainline targets as this ensures that the proposed changes won't e.g. break during some refactoring, etc. So, using MSP430 (probably the smallest) / AVR is perfectly fine for tests, etc.!
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68982/new/
https://reviews.llvm.org/D68982
    
    
More information about the llvm-commits
mailing list