[PATCH] D68438: [gicombiner] Add the run-time rule disable option

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-copy-prop-disabled.mir:5
+# RUN: llc -O0 -run-pass=aarch64-prelegalizer-combiner -global-isel -verify-machineinstrs %s -o - \
+# RUN:     --aarch64prelegalizercombinerhelper-disable-rule=copy_prop | FileCheck --check-prefix=DISABLED %s
+
----------------
volkan wrote:
> Could you add a test case that disables the rule using the ID?
It's not very practical to do so. The ID is stable for a given revision of the compiler but isn't guaranteed to be stable as more rules are added.


================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:400
+     << "#else // ifndef NDEBUG\n"
+     << "  return false;\n"
+     << "#endif // ifndef NDEBUG\n"
----------------
volkan wrote:
> Looks like it's not possible to disable a rule in Release mode. I thought it'd support disabling by rule id, could you double check?
Oops. That's from before I changed my mind about supporting it in Release mode. Fixed it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68438/new/

https://reviews.llvm.org/D68438