[PATCH] D68973: WIP: [LiveDebugValues] Support the debug entry values for modified parameters

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2471
 
+  ///  Return whether this is an operation with a constant offset.
+  bool isOpWithOffset() const;
----------------
This doesn't seem to be a good API. I think this is supposed to recognize some specific high-level pattern, but doesn't really say so? Given how easily salvageDebugInfo keeps appending operations to DIExpressions, it seems very unlikely that this condition would be hit very often.

What's the use-case for this, and is there a better way to achieve the same result?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68973/new/

https://reviews.llvm.org/D68973