[PATCH] D64817: [CMake] Fix LLVM build non-determinism on RHEL

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 12:41:24 PDT 2019


amyk added a comment.

The intention was simply to fix non determinism when building on RHEL, and the version checks were simply to make sure that this patch only gets applied to versions of ar/ranlib that support it.

I didn't realize that the r option on ar also creates a new archive that we can simply test for support on, so I think simply removing all notions of versioning is the correct route to go. If any of the steps fail (non-support), it falls back to using the default so should not cause any new failures. Even with DTS7, we still do not get reproducible builds, so this patch should still apply to all branches.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64817/new/

https://reviews.llvm.org/D64817





More information about the llvm-commits mailing list