[PATCH] D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor.

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 11:26:44 PDT 2019


george.burgess.iv added a comment.

I don't immediately see any issues with this patch, but it's outside of my area of expertise, so I'll defer to the other reviewers :)



================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:1630
+        while (PHINode *PN = dyn_cast<PHINode>(SuccIt++)) {
+          for (unsigned i = 0, e = PN->getNumOperands(); i != e; ++i)
+            if (Instruction *Use = dyn_cast<Instruction>(PN->getOperand(i)))
----------------
tiny nit: `I`/`E` are more consistent with nearby code


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68670/new/

https://reviews.llvm.org/D68670





More information about the llvm-commits mailing list