[PATCH] D68956: [IndVars] Fix a miscompile in off-by-default loop predication implementation
Dávid Bolvanský via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 15 11:08:03 PDT 2019
xbolva00 added inline comments.
================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:2829
+ // after all exit[i] such j > i.
+ for (unsigned i = 0; i < ExitingBlocks.size(); i++)
+ if (BadExit(ExitingBlocks[i])) {
----------------
reames wrote:
> xbolva00 wrote:
> > e = ExitingBlocks.size()
> >
> > i < e
> Done, though, this is a micro-optimization at best. And with a decent compiler, not even that.
>
> (It's common and idiomatic in LLVM code, just noting the reason I don't particularly like it for the record)
Yeah, but we should follow LLVM coding guidelines :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68956/new/
https://reviews.llvm.org/D68956
More information about the llvm-commits
mailing list