[PATCH] D68901: [SampleFDO] Add profile remapping support for profile on-demand loading used by ExtBinary format profile

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1705
+  // to compare name in the module with name in the profile using Remapper.
+  Reader->setRemapper(RemapReader.get());
   ProfileIsValid = (Reader->read() == sampleprof_error::success);
----------------
Better to move line 1705 together with block 1678 to 1693 and make block a helper function  'createRemapper' which does the following
1) create the remapper
2) set reader for the remapper
3) set remapper for the reader.

The call to createRemapper can be moved to line 1705.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68901/new/

https://reviews.llvm.org/D68901