[PATCH] D68975: [LLD] [COFF] Try to report source locations for duplicate symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: lld/COFF/SymbolTable.cpp:523
 
-void SymbolTable::reportDuplicate(Symbol *existing, InputFile *newFile) {
-  std::string msg = "duplicate symbol: " + toString(*existing) + " in " +
-                    toString(existing->getFile()) + " and in " +
-                    toString(newFile);
+static std::string getSourceLocation(BitcodeFile *file) {
+  std::string res("\n>>> defined at ");
----------------
ruiu wrote:
> I wouldn't use function overloading if it can be avoided easily. I'd name this getSourceLocationBitcode and the other getSourceLocationObj.
Ok, will change. There's some predecent of overloading in these functions from before, from D62434 fwiw.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68975/new/

https://reviews.llvm.org/D68975