[PATCH] D68975: [LLD] [COFF] Try to report source locations for duplicate symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: lld/COFF/InputFiles.cpp:794-795
+ObjFile::getVariableLocation(StringRef var) {
+  if (!config->mingw)
+    return None;
+  if (!dwarf) {
----------------
ruiu wrote:
> mstorsjo wrote:
> > ruiu wrote:
> > > You can let clang-cl to generate DWARF and use lld-link to link the object files, so this doesn't have to be mingw-specific?
> > Technically yes, I guess that could be possible, although I don't think there's any setup where that is commonly done. (Or maybe the windows-itanium setup actually?)
> > 
> > We have a similar check for the mingw flag in getFileLine (before calling getFileLineDwarf) though.
> > 
> > Generally I get the feeling that users of lld in msvc style environments want to run as little of these odd mingw cases as possible, but I don't mind removing the checks; running the code in other cases should be harmless.
> I believe some UEFI developers are using clang-cl and lld-link with DWARF debug format. And we publicly say that users can use DWARF on Windows using clang-cl and lld-link, so I think we need to consider this as a supported use pattern.
Okay then; I'll remove the check here. Feel free to remove it from getFileLine in SymbolTable.cpp as well then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68975/new/

https://reviews.llvm.org/D68975