[PATCH] D68959: [lld][WebAssebmly] Fix for LTO with custom import attributes

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

It seems that the patch description is too terse. Please explain the bug that this patch is fixing in the commit message.



================
Comment at: lld/wasm/Driver.cpp:580
 
-static Symbol *addUndefined(StringRef name) {
-  return symtab->addUndefinedFunction(name, "", "", WASM_SYMBOL_UNDEFINED,
-                                      nullptr, nullptr, false);
+static Symbol *addUndefinedWrapper(Symbol* target, StringRef name) {
+  StringRef importModule = defaultModule;
----------------
Can you add a comment to explain what this wrapper provides?


================
Comment at: lld/wasm/SymbolTable.cpp:396
 
+template <typename T>
+static void setImportAttributes(T *existing, StringRef importName,
----------------
Can you add a comment to explain what this function is supposed to do?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68959/new/

https://reviews.llvm.org/D68959