[PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

With the new approach, by building the `GDB 7.11` we confirm that there is no performance regression any more (by using the debug entry values experimental option).

|                |  | -g -O2      |  | -g -O2 -Xclang -femit-debug-entry-values (old approach) |  | -g -O2 -Xclang -femit-debug-entry-values (new approach) |  |
| //build time// |  | 355 seconds |  | 524 seconds                                             |  | 358 seconds                                             |
|

By using the `llvm-locstats` tool, we confirm that the improvement in terms of debug location coverage is still there.

//-The stats from gdb compiled with `-g -O2`://
//llvm-locstats -only-formal-parameters gdb//

  ==================================================
                Debug Location Statistics
  ==================================================
          cov%           samples       percentage(~)
  --------------------------------------------------
          0%               5533            7%
          1-9%             2889            4%
          10-19%           3149            4%
          20-29%           2696            3%
          30-39%           2545            3%
          40-49%           2380            3%
          50-59%           2311            3%
          60-69%           2262            3%
          70-79%           2467            3%
          80-89%           3080            4%
          90-99%          10140            14%
          100%            29982            43%
  ================================================
  -the number of debug variables processed: 69434
  -PC ranges covered: 64%
  ================================================

//-The stats from gdb with entry values (new approach)://
//llvm-locstats -only-formal-parameters gdb//

  ==================================================
                Debug Location Statistics
  ==================================================
          cov%           samples       percentage(~)
  --------------------------------------------------
          0%               5527            7%
          1-9%             1854            2%
          10-19%           2161            3%
          20-29%           1731            2%
          30-39%           1642            2%
          40-49%           1556            2%
          50-59%           1546            2%
          60-69%           1596            2%
          70-79%           1805            2%
          80-89%           2466            3%
          90-99%           6437            9%
          100%            41113            59%
  ================================================
  -the number of debug variables processed: 69434
  -PC ranges covered: 73%
  ================================================


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68209/new/

https://reviews.llvm.org/D68209