[PATCH] D68965: [WebAssembly] Elide data segments for .bss sections

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 20:15:51 PDT 2019


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Great!



================
Comment at: lld/wasm/OutputSections.cpp:219
+                        return !seg->isImplicit;
+                      }) != segments.end();
+}
----------------
You find this easier to read than:

```
for (auto S : segments) 
  if (!seg->isImplicit)
    return true;
return false;
```

?

Maybe I just need get of board with the kids and accept the C++ lambda future that we now live in?  I mean it is kinda cool.

Is there something like python's `any()` builtin in stl that might make this more readable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68965/new/

https://reviews.llvm.org/D68965





More information about the llvm-commits mailing list