[PATCH] D68708: [RFC] Adopt Dexter and use it to run debuginfo-tests

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 15:50:35 PDT 2019


rnk added a comment.
Herald added a subscriber: ormris.

I looked at some of the converted cdb tests, and it looks pretty nice. Thanks for working on this! :)

In the long run, we could try to standardize on using the clang/clang++ command line syntax on Windows if we want to. It would make the tests more similar to the GDB and LLDB tests.



================
Comment at: debuginfo-tests/dexter-tests/inline-line-gap.cpp:42-46
+DexExpectProgramState({'frames':[
+     {'function': 'inlineCrashFrame', 'location':{'lineno' : 'stop'} },
+     {'function': 'callerOfInlineCrashFrame'},
+     {'function': 'main'}
+]})
----------------
This is really cool.


================
Comment at: debuginfo-tests/dexter/dex/debugger/dbgeng/README.md:13-14
+
+This is obviously not a huge amount of fun; on the other hand, COM has
+maintained ABI compatible interfaces for decades, and nothing is for free.
+
----------------
Nice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68708/new/

https://reviews.llvm.org/D68708





More information about the llvm-commits mailing list