[PATCH] D68521: [PATCH 36/38] [noalias] Clang CodeGen for restrict-qualified pointers

Zahira Ammarguellat via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 14:13:46 PDT 2019


zahiraam added inline comments.


================
Comment at: clang/lib/CodeGen/CGDecl.cpp:1925
+    std::string Name = CurFn->getName();
+    Name += ": unknown scope";
+
----------------
Use of Twine would probably be good here?


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:666
+  FnNoAliasInfo.recordMemoryInsts();
+#endif
 
----------------
Remove the #if /#endif pair.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68521/new/

https://reviews.llvm.org/D68521





More information about the llvm-commits mailing list