[PATCH] D66613: [support][llvm-objcopy] Add support for shell wildcards
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 14 14:04:25 PDT 2019
rupprecht updated this revision to Diff 224903.
rupprecht marked 13 inline comments as done.
rupprecht added a comment.
- Remove returns that don't compile
- std::function -> llvm::function_ref
- Update docs
- Fix punctuation
- Clarify wildcard vs glob
- Use better check prefixes
- Change letters to avoid any locale issues
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66613/new/
https://reviews.llvm.org/D66613
Files:
llvm/docs/CommandGuide/llvm-objcopy.rst
llvm/docs/CommandGuide/llvm-strip.rst
llvm/include/llvm/Support/GlobPattern.h
llvm/lib/Support/GlobPattern.cpp
llvm/test/tools/llvm-objcopy/ELF/wildcard-flags.test
llvm/test/tools/llvm-objcopy/ELF/wildcard-syntax.test
llvm/tools/llvm-objcopy/CommonOpts.td
llvm/tools/llvm-objcopy/CopyConfig.cpp
llvm/tools/llvm-objcopy/CopyConfig.h
llvm/tools/llvm-objcopy/llvm-objcopy.cpp
llvm/unittests/Support/GlobPatternTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66613.224903.patch
Type: text/x-patch
Size: 42505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191014/b1da8c24/attachment.bin>
More information about the llvm-commits
mailing list