[PATCH] D68905: [update_mir_test_checks] Handle MI flags properly

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin marked 2 inline comments as done.
rtereshin added inline comments.


================
Comment at: utils/update_mir_test_checks.py:37-38
+MI_FLAGS_STR= (
+    r'(frame-setup |frame-destroy |nnan |ninf |nsz |arcp |contract |afn '
+    r'|reassoc |nuw |nsw |exact |fpexcept )*')
 VREG_DEF_RE = re.compile(
----------------
bogner wrote:
> It'd be kind of nice if we could ensure this list stays up to date somehow, but I suppose it really doesn't change much and we'll notice the first time someone updates a test with a flag that's missing here.
Also, the list of flags in the MI def itself, the MIRParser part that handles them, as well as MIRPrinter are all hand-written and kept in sync manually at the moment. I think it's all good enough for now, if it becomes a problem, we will probably be looking into bigger fish to fry when it comes to keeping in sync everything that has to do with MIR syntax.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68905/new/

https://reviews.llvm.org/D68905