[PATCH] D67698: [RISCV] Remove RA from reserved register to use as callee saved register
Sam Elliott via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 14 08:15:48 PDT 2019
lenary added a comment.
We had a discussion internally at lowRISC about this. I no longer think that debuggability is a concern, as FP/CFI-info is far more important than the return address. Alex has raised that preserving RA is useful for some lightweight tracing applications, but I feel that can be solved with the implementation of `-ffixed-x1` (D67185 <https://reviews.llvm.org/D67185>).
With that in mind, we're happy to approve this patch, pending the following:
Please can you rebase it? It applies, but tests fail. Looks like a simple update caused by a change to the materialisation of the address of `var`.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67698/new/
https://reviews.llvm.org/D67698
More information about the llvm-commits
mailing list