[PATCH] D68493: [PATCH 10/38] [noalias] simplify noalias intrinsics

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere marked 2 inline comments as done.
jeroen.dobbelaere added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5148
+  if (isa<UndefValue>(Op0) || (isa<ConstantPointerNull>(Op0) &&
+                               Op0->getType()->getPointerAddressSpace() == 0)) {
+    return Op0;
----------------
As mentioned by a.elivikov in D68492: we should not propagate `null` through the intrinsics.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5225
+    if (isa<UndefValue>(Op0) ||
+        (isa<ConstantPointerNull>(Op0) &&
+         Op0->getType()->getPointerAddressSpace() == 0)) {
----------------
Also here, we should not propagate `null`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68493/new/

https://reviews.llvm.org/D68493