[PATCH] D68906: [llvm-size] Tidy up error messages
Alex Cameron via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 14 03:27:36 PDT 2019
tetsuo-cpp marked 2 inline comments as done.
tetsuo-cpp added a comment.
Thanks for the reviews @MaskRay and @grimar.
If you're still happy with this patch, could one of you please commit on my behalf?
================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:113
+ WithColor::error(errs(), ToolName) << "'" << File << "': " << Message << "\n";
errs().flush();
}
----------------
grimar wrote:
> FTR, I think error stream is unbuffered, i.e. no need to `flush()`, but it is probably unrelated to this patch.
Yep, it looks like it is indeed unbuffered so I've removed the `flush`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68906/new/
https://reviews.llvm.org/D68906
More information about the llvm-commits
mailing list