[PATCH] D68400: [NFC][TTI] Add Alignment for isLegalMasked[Load/Store]

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 00:47:28 PDT 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4543
     return isa<LoadInst>(I) ?
-        !(isLegalMaskedLoad(Ty, Ptr)  || isLegalMaskedGather(Ty))
-      : !(isLegalMaskedStore(Ty, Ptr) || isLegalMaskedScatter(Ty));
+        !(isLegalMaskedLoad(Ty, Ptr, Alignment) || isLegalMaskedGather(Ty))
+      : !(isLegalMaskedStore(Ty, Ptr, Alignment) || isLegalMaskedScatter(Ty));
----------------
dmgreen wrote:
> Does this need to be a MaybeAlign(Alignment)? Because the constructor is explicit, as far as I understand (hence, needs to look like the others).
These are the internal helper functions, so they're constructed explicitly there. lines 1172 and 1179.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68400/new/

https://reviews.llvm.org/D68400





More information about the llvm-commits mailing list