[PATCH] D68898: JumpThreading: enhance JT to handle BB with no successor and address comparison

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

Handling what Wei's case will be a nice thing to have, but it may require more significant change in JT. Currently the JT candidate BB selection is based on checking the conditional value used by branch or return value of ret instr (with this patch).

To handle this case, it requires checking use values of arbitrary instructions (value of store in the example).   Another thing to consider is the cost model difference. In Wei's case, cloning really becomes tail dup with increased complexity of control flow (handling Ret instruction on the other hand does not have the issue).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68898/new/

https://reviews.llvm.org/D68898