[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 11 15:29:08 PDT 2019


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

I would still prefer no-inline-info or no-inline-debuginfo over no-inline-linetables and a line 0 location for the inlined instructions. Other than that the patch is now safe.



================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1431
+        }
+        BI->setDebugLoc(TheCallDL);
+        continue;
----------------
I still think an artificial (line 0) location would be less misleading for debuggers, profilers, and optimization remarks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67723/new/

https://reviews.llvm.org/D67723





More information about the llvm-commits mailing list