[PATCH] D67322: [LLD][ThinLTO] Handle GUID collision in import global processing

[Joel Klinghed via Phabricator via llvm-commits]

the_jk added a comment.

Another place that already handles multiple locals with the same GUID is in the same file: bool FunctionImportGlobalProcessing::shouldPromoteLocalToGlobal(), from a comment there:

  // When exporting, consult the index. We can have more than one local
  // with the same GUID, in the case of same-named locals in different but
  // same-named source files that were compiled in their respective directories
  // (so the source file name and resulting GUID is the same). Find the one
  // in this module.

so I think raising an error would cause surprises for different setups. 
I'll gladly add more testcases if you can give me some ideas/tips on possible problems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67322/new/

https://reviews.llvm.org/D67322