[PATCH] D68672: [APInt] Rounding right-shifts

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 13 00:30:01 PDT 2019


lebedev.ri added a comment.

In D68672#1707312 <https://reviews.llvm.org/D68672#1707312>, @nikic wrote:

> > I'd like to try to extend ConstantRange::makeGuaranteedNoWrapRegion()
> >  to deal with Instruction::Shl so i believe i need rounding right shifts.
>
> I don't think rounding shifts are strictly necessary for this purpose,




> the correct behavior should fall out when applying the normal lshr/ashr operations to -1 / signed_min / signed_max.

I'm not sure i can parse that, fall out?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68672/new/

https://reviews.llvm.org/D68672





More information about the llvm-commits mailing list